-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default-authorization-mode
feature flag
#7996
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @creydr |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7996 +/- ##
==========================================
- Coverage 67.57% 67.55% -0.03%
==========================================
Files 355 355
Lines 16551 16564 +13
==========================================
+ Hits 11184 11189 +5
- Misses 4677 4683 +6
- Partials 690 692 +2 ☔ View full report in Codecov by Sentry. |
# authorization mode for resources that have no EventPolicy associated with them. | ||
# | ||
# This feature flag is only used when "authentication-oidc" is enabled. | ||
default-authorization-mode: "allow-same-namespace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use "allow-all" as the default at the beginning, to not break users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is applied only when authn is enabled and that feature is alpha, I'd go directly with the one that is most sensible for the future ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
/test upgrade-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixes #7974
Proposed Changes
default-authorization-mode
feature flagPre-review Checklist
Release Note
Docs